-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for async I/O #1203
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see asyncio support in the main code base! I left a couple of comments and suggestions mostly in the implementation of the new connection class.
vEpiphyte
reviewed
Apr 20, 2020
vEpiphyte
reviewed
Apr 20, 2020
2 tasks
Closed in favor of #1230, thanks for all the early review comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elasticsearch/_async/client/...
code using normal workflowunasync
to translate async code to sync code inelasticsearch/client/...
AsyncElasticsearch
,AsyncTransport
, andAIOHttpConnection
into theelasticsearch
namespace.AsyncElasticsearch
in the global scope, outside an event loop.perform_request()
or call to__aenter__()
AsyncElasticsearch
and how to useelasticsearch-async
repositoryaiohttp
as an extraelasticsearch[async]
?