New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cat.py should allow for shards to utilize bytes. #630

Closed

jb4x opened this issue Aug 10, 2017 · 3 comments

Assignees

jb4x commented Aug 10, 2017 •

edited

Loading

I had a customer asking for support for bytes in shards within the python api.

It looks like it would be pretty simple to alter here:

elasticsearch-py/elasticsearch/client/cat.py

Line 204 in 843ce9e

@query_params('format', 'h', 'help', 'local', 'master_timeout', 's', 'v')

GlenRSmith self-assigned this

Contributor

honzakral commented Aug 11, 2017

If cat.shards should accept byte we should also fix it in https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/cat.shards.json which is the authoritative source for API parameters (see https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/cat.fielddata.json#L19-L23 for example)

Contributor

GlenRSmith commented Oct 10, 2017

elastic/elasticsearch#26952

Contributor

GlenRSmith commented Oct 11, 2017

Resolved by #654

GlenRSmith closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment