Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guzzlehttp/ringphp and guzzlehttp/streams are abandoned #992

Closed
reedy opened this issue Jan 24, 2020 · 6 comments · Fixed by #996
Closed

guzzlehttp/ringphp and guzzlehttp/streams are abandoned #992

reedy opened this issue Jan 24, 2020 · 6 comments · Fixed by #996
Assignees

Comments

@reedy
Copy link
Contributor

reedy commented Jan 24, 2020

https://packagist.org/packages/guzzlehttp/ringphp is marked as abandoned, with no replacement

guzzle/ringphp depends on https://packagist.org/packages/guzzlehttp/streams which is also marked as abandoned, with no replacement

@cspshadx
Copy link

bump. got same warning from composer. any suggestions?

@ezimuel
Copy link
Contributor

ezimuel commented Jan 28, 2020

We are planning to refactor all the HTTP transport using PSR and/or HTTPlug and/or Symfony HttpClient (more detail here: #990). This will be released with elasticsearch-php 8.0.
In the meantime, we need to find a solution for the ringphp replacement but we don't want to do double work here since we have the 8.0 plan in place.
@cspshadx, @reedy I'll update you asap.

@ezimuel ezimuel self-assigned this Jan 28, 2020
@orukaz
Copy link

orukaz commented Jan 30, 2020

@reedy and @ezimuel , I think the replacement is Guzzle 6 GuzzleHttp\Handler namespace: http://docs.guzzlephp.org/en/stable/handlers-and-middleware.html

For example: googleapis/google-api-php-client#1106

With 6th version of "guzzlehttp/guzzle" you get error:

"guzzlehttp/ringphp" (https://github.com/guzzle/RingPHP) dependency is not loaded by composer because

Guzzle no longer has a dependency on RingPHP. Due to the use of a middleware
system based on PSR-7, using RingPHP and it's middleware system as well adds
more complexity than the benefits it provides. All HTTP handlers that were
present in RingPHP have been modified to work directly with PSR-7 messages
and placed in the GuzzleHttp\Handler namespace. This significantly reduces
complexity in Guzzle, removes a dependency, and improves performance. RingPHP
will be maintained for Guzzle 5 support, but will no longer be a part of
Guzzle 6.

@reedy reedy changed the title ringphp is abandoned guzzle/ringphp and guzzle/streams are abandoned Feb 3, 2020
@reedy reedy changed the title guzzle/ringphp and guzzle/streams are abandoned guzzlehttp/ringphp and guzzlehttp/streams are abandoned Feb 3, 2020
@reedy
Copy link
Contributor Author

reedy commented Feb 3, 2020

Bringing in all of Guzzle seems overkill... Though it seems 1.0 used to do that.

RingPHP will be maintained for Guzzle 5 support, but will no longer be a part of Guzzle 6.

https://packagist.org/packages/guzzlehttp/guzzle says Guzzle 5 is EOL (since late October 2019 based on guzzle/guzzle@4d71358), so I guess that means ringphp (and streams) also no longer have any maintenance, as they're not being maintained for Guzzle 5 anymore. Presumably they just took a little while to catch up on the repo maintenance and to mark it abandoned etc

I would guess trying to backport #990 to < 8 might be a pain, considering it basically includes, 2.0, 5.0, 6.0, 6.7, 6.7, 7.0, 7.2 and 7.4...

@ezimuel
Copy link
Contributor

ezimuel commented Feb 12, 2020

@reedy @orukaz @cspshadx After some code review and since I'm going to refactor all the HTTP transport layer for elasticsearch-php 8.0.0, I decided to fork guzzlehttp/ringphp and guzzlehttp/streams and use this fork for elasticsearch-php 7.x. This means, I'll mantain these forks in the meanwhile. I'm preparing a PR for that.

@ezimuel
Copy link
Contributor

ezimuel commented Feb 13, 2020

I just sent the PR #996, please have a look thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants