Associate an external id with a task, so that it can be cancelled later. #3277
Conversation
| public bool Cancellable { get; internal set; } | ||
|
|
||
| [JsonProperty("headers")] | ||
| public IReadOnlyDictionary<string, string> Headers { get; internal set; } = EmptyReadOnly<string, string>.Dictionary; |
There was a problem hiding this comment.
LGTM, do we know what headers are possibly returned here?
There was a problem hiding this comment.
Sadly not (from the source code I read) but certainly X-Opaque-Id.
I had considered a helper method to expose this value, but just left to the user for the time being...
| /// Associate an Id with this user-initiated task, such that it can be located in the cluster task list. | ||
| /// <pre>https://www.elastic.co/guide/en/elasticsearch/reference/master/tasks.html#_identifying_running_tasks</pre> | ||
| /// </summary> | ||
| string OpaqueId { get; set; } |
There was a problem hiding this comment.
Add something to indicate that this is valid only for Elasticsearch 6.2.0+
| /// Associate an Id with this user-initiated task, such that it can be located in the cluster task list. | ||
| /// <pre>https://www.elastic.co/guide/en/elasticsearch/reference/6.2/tasks.html#_identifying_running_tasks</pre> | ||
| /// </summary> | ||
| public RequestConfigurationDescriptor OpaqueId(string opaqueId) |
There was a problem hiding this comment.
Add something to indicate that this is valid only for Elasticsearch 6.2.0+
There was a problem hiding this comment.
I think rather than having a link to docs, something like "Valid for Elasticsearch 6.2.0+" would be sufficient.
| @@ -36,5 +36,8 @@ public class TaskInfo | |||
|
|
|||
| [JsonProperty("cancellable")] | |||
| public bool Cancellable { get; internal set; } | |||
|
|
|||
| [JsonProperty("headers")] | |||
| public IReadOnlyDictionary<string, string> Headers { get; internal set; } = EmptyReadOnly<string, string>.Dictionary; | |||
| } | |||
There was a problem hiding this comment.
missing child tasks in children array?
There was a problem hiding this comment.
Good catch, have added.
|
Backported to |
Closes #3259