Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes in Nested Filter #428

Closed
klappvisor opened this issue Dec 23, 2013 · 3 comments
Closed

Breaking Changes in Nested Filter #428

klappvisor opened this issue Dec 23, 2013 · 3 comments
Labels
Milestone

Comments

@klappvisor
Copy link

According to documentation of elasticsearch v0.90.9 nested filter has been changed and looks slightly different now. Also scope support has been removed (elastic/elasticsearch#2606) from queries and filters. I'd like to contribute but this is important breaking changes and I think it would be better to ask you first about your plans to introduce breaking changes in NEST?

@klappvisor
Copy link
Author

Any way it seems to be necessary to introduce these breaking changes because elasticsearch server throws an exception about _scope...

@Mpdreamz
Copy link
Member

This is a difficult one,

I'm working hard one the https://github.com/Mpdreamz/NEST/tree/api-changes branch to stabilise my own IElasticClient api which will make the typed calls itself really easy to implement (see https://github.com/Mpdreamz/NEST/blob/api-changes/src/Nest/ElasticClient-Validate.cs)

I was going to release this as NEST 0.90.0 and use the 0.90.0 range as the last batch of versions to support the 0.90.* versions of elasticsearch

Elasticsearch 1.0 introduces several breaking changes (aliases, percolator have substantially changed amongst others).

NEST 1.0 will be compatible with elasticsearch 1.0 and integration tests will run only on elasticsearch 1.0.
NEST 0.90 will be compatible with elasticsearch 0.90.*

I'll support the 0.90 branch of NEST for atleast a year

This breaking change complicates my plans to accomodate the jump to 1.0 though. Will have to think about this! Suggestions welcome!

@Mpdreamz Mpdreamz added this to the NEST 1.0 milestone Feb 6, 2014
@Mpdreamz Mpdreamz added this to the NEST 1.0 RC milestone Jun 16, 2014
@Mpdreamz
Copy link
Member

Mpdreamz commented Jul 9, 2014

@klappvisor it took a while but this has now been added (removing scope and adding join property to nested filter).

Thanks for opening the issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants