Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using async-http as a transport #72

Open
ioquatix opened this issue Dec 23, 2019 · 5 comments
Open

Using async-http as a transport #72

ioquatix opened this issue Dec 23, 2019 · 5 comments

Comments

@ioquatix
Copy link

Async::HTTP is an asynchronous persistent and scalable HTTP client which works very well within the Falcon server.

I have been reading https://github.com/elastic/elasticsearch-ruby/blob/master/elasticsearch-transport/README.md#transport-implementations but it's not clear how you achieve thread safety.

Do you use one faraday connection instance per client?

Are you aware of the new hooks to manage life-cycle of persistent connections? e.g. Faraday::Connection#close?

Do you expose those methods from the client?

Just wondering how best to support elasticsearch.

@picandocodigo
Copy link
Member

Hi @ioquatix,
I'm the new maintainer for this project and I'm currently working on several things. But I have added this query to my list and I'll get back to you as soon as possible.

Thank you,
Cheers!

@ioquatix
Copy link
Author

Ping.

1 similar comment
@ajjahn
Copy link

ajjahn commented Apr 2, 2021

Ping.

@ioquatix
Copy link
Author

ioquatix commented Apr 3, 2021

Pong.

@picandocodigo picandocodigo transferred this issue from elastic/elasticsearch-ruby Oct 25, 2023
@picandocodigo
Copy link
Member

Hi @ioquatix, I've transferred this issue to the new home for elastic-transport. You can see how connections are handled in base.rb and the different implementatiosn in http. You can write a new implementation by including Elastic::Transport::Base and implementing the API.

Adding support for Async::HTTP is not on our roadmap at the moment, but we'll gladly review the code if you submit a PR.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants