Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: BigDecimal.new is deprecated; use BigDecimal() method instead. in multi_json 1.15.0 #42

Open
hphucnp opened this issue Nov 2, 2022 · 1 comment

Comments

@hphucnp
Copy link

hphucnp commented Nov 2, 2022

We got the bigdecimal warning poping up every milisecond when using elasticsearch ruby client.
Do anybody have anyidea to fix this issue?

/bundle/ruby/2.6.0/gems/multi_json-1.15.0/lib/multi_json/adapters/oj.rb:34: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.

image

I think we can remove multi_json lib because it seems not to be maintained since 2020

@picandocodigo
Copy link
Member

@hphucnp thanks for reporting this, I'll look into the possibility of replacing multi_json as the default serializer, since it seems to not be maintained anymore. I think we can add another implementation based off Elastic::Transport::Transport::Serializer::Base and keep this one as an option for backwards compatibility. Also, I'm transferring this issue to elastic-transport, since that's where the JSON serializer is used

@picandocodigo picandocodigo transferred this issue from elastic/elasticsearch-ruby Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants