Add false positive test package to detect errors in elastic agent logs #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
1 similar comment
|
/test |
This reverts commit 782322c.
jsoriano
reviewed
Sep 6, 2024
| # Copy XML files to another extension so they are not used to check jUnit tests | ||
| # but those files will be able to be reviewed afterwards | ||
| for file in $(ls $result_tests) ; do | ||
| cp "${file}" "${file}.txt" |
There was a problem hiding this comment.
Nit. Could we add some meaningful suffix?
Suggested change
| cp "${file}" "${file}.txt" | |
| cp "${file}" "${file}-expected-errors.txt" |
| @@ -59,6 +59,11 @@ function check_expected_errors() { | |||
| cat ${results_no_spaces} | grep -E "${line}" | |||
| done < "${expected_errors_file}" | |||
|
|
|||
| # Copy XML files to another extension so they are not used to check jUnit tests | |||
| # but those files will be able to be reviewed afterwards | |||
jsoriano
approved these changes
Sep 6, 2024
|
/test |
1 similar comment
|
/test |
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1811
Added a new test package into
false_positivesto be able to check if there is any error in the logs from Elastic Agent container.This package requires to be executed in a specific Elastic stack version 8.12.0 in order to reproduce the error.
Tested failure (not detected error logs) build (using 8.12.1):