[docs] Update system testing docs #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Sep 3, 2024
Comment on lines
+646
to
+647
| **IMPORTANT**: The provisioning script must exit with a code different from zero in case any of the commands defined fails. | ||
| That will ensure that the docker build step run by `elastic-package` fails too. |
There was a problem hiding this comment.
Add a note about the importance of ensuring that the provisioning script fails if any command of the script fails.
💚 Build Succeeded
cc @mrodm |
jsoriano
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example of a provisioning script (oracle test package).
And add a note to make sure the script finishes with error if any command fail.