[system tests] Add support for systemd option in agent.base_image setting #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Sep 2, 2024
Comment on lines
+179
to
+181
| default: | ||
| return selectElasticAgentCompleteImageName(v) | ||
| } |
There was a problem hiding this comment.
Keep the same behaviour as it was previously. It means using the complete image whenever it is possible.
jsoriano
approved these changes
Sep 2, 2024
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to run system tests using the regular Elastic Agent docker image (e.g. docker.elastic.co/elastic-agent/elastic-agent).
It will take into account the Elastic stack version to use
docker.elastic.co/beats/elastic-agentdocker image when it is required.If there is no value defined for
agent.base_imageor it has thedefaultvalue, the behaviour would be as it was up to now. It would use the complete image where it is supported.Changed required in the spec: elastic/package-spec#792