Disable subobjects by default on new packages and data streams #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsHistorycc @jsoriano |
mrodm
reviewed
Jul 11, 2024
Comment on lines
+77
to
+82
| {{ if .Manifest.Elasticsearch.SourceMode }} | ||
| source_mode: {{ .Manifest.Elasticsearch.SourceMode }} | ||
| {{- end}} | ||
| {{ if .Manifest.Elasticsearch.IndexMode }} | ||
| index_mode: {{ .Manifest.Elasticsearch.IndexMode }} | ||
| {{- end }} |
There was a problem hiding this comment.
Currently, there are no questions for these values when creating the package. So, right now they would not be written here in this manifest.
Should they be added also as part of the questions?
There was a problem hiding this comment.
Not sure, I could add them in a follow up if necessary. Or would you prefer the questions to be added here?
There was a problem hiding this comment.
Sure, they can be added in a follow up, it's not needed to do it now.
mrodm
approved these changes
Jul 11, 2024
Comment on lines
+77
to
+82
| {{ if .Manifest.Elasticsearch.SourceMode }} | ||
| source_mode: {{ .Manifest.Elasticsearch.SourceMode }} | ||
| {{- end}} | ||
| {{ if .Manifest.Elasticsearch.IndexMode }} | ||
| index_mode: {{ .Manifest.Elasticsearch.IndexMode }} | ||
| {{- end }} |
There was a problem hiding this comment.
Sure, they can be added in a follow up, it's not needed to do it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the archetypes used by
elastic-package createto disable subobjects by default on new packages and data streams.A new question is added to the survey so users can chose to opt out for this behavior.
Closes #1872.