Add security-rule kibana assets to be checked by tests #1960
Conversation
internal/packages/assets.go
Outdated
| @@ -159,7 +162,7 @@ func loadElasticsearchAssets(pkgRootPath string) ([]Asset, error) { | |||
| } | |||
|
|
|||
| func loadFileBasedAssets(kibanaAssetsFolderPath string, assetType AssetType) ([]Asset, error) { | |||
| assetsFolderPath := filepath.Join(kibanaAssetsFolderPath, string(assetType)) | |||
| assetsFolderPath := filepath.Join(kibanaAssetsFolderPath, strings.ReplaceAll(string(assetType), "-", "_")) | |||
There was a problem hiding this comment.
Folder in packages is names security_rule, but the type name is security-rule.
There was a problem hiding this comment.
Nit. Maybe add this as a comment to understand why we do the replace? Or maybe we could make AssetType more explicit, with a type that contains the asset type name and the folder name.
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#10435 |
internal/packages/assets.go
Outdated
| @@ -159,7 +162,7 @@ func loadElasticsearchAssets(pkgRootPath string) ([]Asset, error) { | |||
| } | |||
|
|
|||
| func loadFileBasedAssets(kibanaAssetsFolderPath string, assetType AssetType) ([]Asset, error) { | |||
| assetsFolderPath := filepath.Join(kibanaAssetsFolderPath, string(assetType)) | |||
| assetsFolderPath := filepath.Join(kibanaAssetsFolderPath, strings.ReplaceAll(string(assetType), "-", "_")) | |||
There was a problem hiding this comment.
Nit. Maybe add this as a comment to understand why we do the replace? Or maybe we could make AssetType more explicit, with a type that contains the asset type name and the folder name.
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#10435 |
💚 Build Succeeded
History
cc @mrodm |
Follows #1915
Include
security-ruleassets into the assets checked byelastic-package test asset.Those kibana assets are reported by the fleet API:
Example of response (truncated):
{ "response": { ... "savedObject": { "id": "security_detection_engine", "type": "epm-packages", "namespaces": [], "updated_at": "2024-07-09T14:33:46.715Z", "created_at": "2024-07-09T14:33:45.355Z", "version": "WzcxMTEsMV0=", "attributes": { "installed_kibana": [ { "id": "000047bb-b27a-47ec-8b62-ef1a5d2c9e19_106", "type": "security-rule" }, ... ], }, }, }, }