Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set independent Elastic Agents as default for system tests #1959

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Set independent Elastic Agents as default for system tests #1959

merged 2 commits into from
Jul 10, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 9, 2024 •
edited
Loading

Closes #1954

This PR sets as default running independent Elastic Agents. This can be disabled by setting the environment variable ELASTIC_PACKAGE_TEST_ENABLE_INDEPENDENT_AGENT to false. Example:

# Option a: exporting the variable
export ELASTIC_PACKAGE_TEST_ENABLE_INDEPENDENT_AGENT=false
elastic-package test -v

# Option b: defining directly the variable in the same command
ELASTIC_PACKAGE_TEST_ENABLE_INDEPENDENT_AGENT=false elastic-package test -v

CI has also been updated accordingly.

Checklist

Test packages using old Custom agents:

  • Run system tests in auditd_manager package from integrations repository
  • Run system tests in oracle package from integrations repository

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 9, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@mrodm mrodm marked this pull request as ready for review July 9, 2024 17:02
@mrodm mrodm requested a review from a team as a code owner July 9, 2024 17:02
jlind23
jlind23 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsoriano
jsoriano approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and nice cleanup, thanks!

@mrodm mrodm merged commit 24c5fb3 into elastic:main Jul 10, 2024
3 checks passed
@mrodm mrodm deleted the use-default-independent-elastic-agents branch July 10, 2024 12:56
This was referenced Jul 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run independent Elastic Agents by default
4 participants
@mrodm @elasticmachine @jsoriano @jlind23