Refactor PTTY handling in compose commands

[jsoriano]

Use the helper pty.Start() instead of handling ourselves the tty and associated ptty. Wait for the finalization of the command just with the copy, to avoid a separate goroutine in an attempt to avoid the hangs we are seeing in CI.

Downgrade to pty 1.1.19, that seems to solve some kind of race condition creack/pty#196

[jsoriano]

test integrations

[elasticmachine]

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10202

[jsoriano]

/test

[jsoriano]

/test

[jsoriano]

/test

[jsoriano]

test integrations

[elasticmachine]

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10202

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 47bfd8f

History

• 💚 Build #3493 succeeded 621c6c1
• 💚 Build #3482 succeeded 621c6c1
• 💚 Build #3481 succeeded 621c6c1
• 💚 Build #3479 succeeded 621c6c1

cc @jsoriano

[mrodm]

test integrations

[elasticmachine]

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10202

[mrodm]

Nice !!

Just one question , will dependabot try to update this version again to the version that has those issues?

[jsoriano]

will dependabot try to update this version again to the version that has those issues?

Yes, I think so. We will have to close the PR so the version is ignored, and in future versions review if the issue has been fixed.

[jsoriano]

This should be enough: #1931 (comment)