Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent running services of different profiles #962

Closed
Tracked by #1158
jsoriano opened this issue Sep 8, 2022 · 0 comments · Fixed by #1140
Closed
Tracked by #1158

Prevent running services of different profiles #962

jsoriano opened this issue Sep 8, 2022 · 0 comments · Fixed by #1140
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

jsoriano commented Sep 8, 2022

With tricky combinations of elastic-package stack flags, it is possible to end up with an scenario with services started with different profiles. This can cause that some services cannot connect with the others because they are on different networks or because they use certificates signed by different CAs, as described in #959.

We could make elastic-package stack more aware of profiles, and fail when executed with a profile when there are services of other profiles running. A possible way to do it would be to check the labels of the services started, for example they will have different com.docker.compose.project.config_files and com.docker.compose.project.working_dir labels.

A more powerful alternative could be to allow to start the stack of different profiles at the same time with more isolation, but we would need to expose the ports in the host in a different way to avoid conflicts. I think that by now it'd be enough with preventing running resources of mixed profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants