Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-request: option to pin local registry image #804

Closed
efd6 opened this issue Apr 28, 2022 · 11 comments
Closed

feature-request: option to pin local registry image #804

efd6 opened this issue Apr 28, 2022 · 11 comments
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@efd6
Copy link
Contributor

efd6 commented Apr 28, 2022

When bringing the stack up, currently elastic-package gets the latest snapshot of the registry. This is almost always the right thing to do. However, on occasions when the most current registry is not required, but the stack needs to be restarted the need to pull ~900MB impacts on developer iteration time, and in some cases available bandwidth.

It would be nice if it were possible for the user to pin the image that docker compose uses to the image that is available on local storage rather than getting the current snapshot.

@jlind23 jlind23 added the Team:Ecosystem Label for the Packages Ecosystem team label Apr 28, 2022
@efd6
Copy link
Contributor Author

efd6 commented Jul 18, 2022

An alternative approach which would satisfy the development use case would be to enable pulling a naked registry that only uses the local packages by tagging the image prior to the addition of the package data during the image build. This would reduce the pull size by about 100 fold and would be enable rapid iteration while developing/debugging packages.

@jsoriano
Copy link
Member

@efd6 yes, we are considering using a bare image for package development.

elastic/kibana#70582 would also allow to do package development without even needing a registry.

@efd6
Copy link
Contributor Author

efd6 commented Aug 17, 2022

Is there a timeframe for this? It is a significant pain point for development.

@jsoriano
Copy link
Member

@efd6 is this an issue when running elastic-package stack up only or when elastic-package stack update is involved?

Btw, as part of the storage v2 efforts we have started to build a "lite" image, that could help with this.

elastic/package-registry#770 can also help as then the local registry would be minimal.

@efd6
Copy link
Contributor Author

efd6 commented Aug 17, 2022

The happens when I do a stack up, even just to pick up changes for system testing with elastic-package stack up -d -v -s package-registry. With bad timing, what should take a minute or so, takes as long as needed to pull, now, 1GB.

@jsoriano
Copy link
Member

Umm, there may be some issue there, I think elastic-package stack up shouldn't pull images that are locally available.

@jsoriano
Copy link
Member

Yes, I currently have an outdated version of docker.elastic.co/package-registry/distribution:snapshot, and the new one is not downloaded by elastic-package stack up, but it is if I run elastic-package stack update.

@efd6 what versions of elastic-package and docker-compose are you using?

@efd6
Copy link
Contributor Author

efd6 commented Aug 17, 2022

Docker Compose version v2.6.1
elastic-package 353ea87

@mtojek
Copy link
Contributor

mtojek commented Sep 7, 2022

We implemented the proxy mode, so I guess that this issue isn't relevant anymore.

@mtojek mtojek closed this as completed Sep 7, 2022
@efd6
Copy link
Contributor Author

efd6 commented Sep 7, 2022

Is there documentation for how that would be used to solve this.

@mtojek
Copy link
Contributor

mtojek commented Sep 7, 2022

No, it's enabled by default. It's transparent for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

No branches or pull requests

4 participants