Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update resource detectors to used the DetectorSync API #329

Closed
4 tasks
david-luna opened this issue Aug 12, 2024 · 2 comments
Closed
4 tasks

update resource detectors to used the DetectorSync API #329

david-luna opened this issue Aug 12, 2024 · 2 comments
Assignees
@david-luna

Comments

@david-luna
Copy link
Member

david-luna commented Aug 12, 2024 •
edited
Loading

Latest release and upcoming release of opentelemetry contrib included some updates in resource detectors. These new versions replace the deprecated Detector API in favour of DetectorSync. We should update them.

Check list:

  • resource-detector-alibaba-cloud: 0.29.0
  • resource-detector-aws: 1.6.0
  • resource-detector-azure: 0.2.10
  • resource-detector-container: 0.4.0
@david-luna david-luna self-assigned this Aug 12, 2024
This was referenced Aug 12, 2024
Closed
Closed
@david-luna
Copy link
Member Author

we will be able to update once open-telemetry/opentelemetry-js-contrib#2375 is merged. There are other updates in detectors planed but they will eventually get in with the usual dependabot/renovate process

@david-luna
Copy link
Member Author

Decided to let dependabot handle this in https://github.com/elastic/apm-nodejs-dev/issues/53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-luna david-luna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(otel-node): update resource detectors elastic/elastic-otel-node
1 participant
@david-luna