Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: update chart line and grid styles and colors #2492

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Jul 19, 2024

Summary

Updates line and color styles.

Changes:

  • Remove dashed lines for horizontal gridlines
  • Set LIGHT_THEME grid lines color to #E9EDF3

No Changes required (as is currently):

  • Set DARK_THEME grid lines color to #343741 (i.e. EUI.colors.lightShade)
  • Bucket dashed line on hover color (i.e. crosshair.line) set to EUI.colors.darkShade

Issues

closes #2459

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • Visual changes have been tested with light and dark themes

@nickofthyme nickofthyme added :styling Styling related issue :xy Bar/Line/Area chart related labels Jul 19, 2024
@nickofthyme nickofthyme requested a review from gvnmagni July 19, 2024 22:17
Copy link
Collaborator Author

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gvnmagni Can you take a look at the requested changes? Here is a link to the storybook with the gridline options.

packages/charts/src/utils/themes/dark_theme.ts Outdated Show resolved Hide resolved
@nickofthyme
Copy link
Collaborator Author

buildkite update screenshots

@nickofthyme nickofthyme marked this pull request as ready for review July 22, 2024 18:41
@nickofthyme
Copy link
Collaborator Author

Large VRT diff (900+) due to changes in gridline dash and color styles.

@nickofthyme
Copy link
Collaborator Author

buildkite update screenshots

@nickofthyme nickofthyme merged commit 2eda7a2 into elastic:main Jul 29, 2024
14 checks passed
@nickofthyme nickofthyme deleted the styles-per-2459 branch July 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:styling Styling related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Grids] Minor style update
3 participants