Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply positioning to hidden tooltip #716

Merged

Conversation

markov00
Copy link
Member

Summary

Fix the scrollbar appearance when showing a tooltip on Lens/Kibana.
This was caused by the invisible class and its child taking space on the bottom of the page before popperjs can position the tooltip on the page

@markov00 markov00 added bug Something isn't working :tooltip Related to hover tooltip labels Jun 16, 2020
@markov00 markov00 requested a review from nickofthyme June 16, 2020 21:32
@codecov-commenter
Copy link

Codecov Report

Merging #716 into master will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   74.80%   75.16%   +0.36%     
==========================================
  Files         265      280      +15     
  Lines        8541     8842     +301     
  Branches     1714     1741      +27     
==========================================
+ Hits         6389     6646     +257     
- Misses       2099     2138      +39     
- Partials       53       58       +5     
Impacted Files Coverage Δ
src/components/portal/tooltip_portal.tsx 65.62% <100.00%> (ø)
src/mocks/geometries.ts 86.84% <0.00%> (ø)
src/mocks/series/utils.ts 100.00% <0.00%> (ø)
src/mocks/utils.ts 100.00% <0.00%> (ø)
src/mocks/index.ts 100.00% <0.00%> (ø)
src/mocks/theme.ts 100.00% <0.00%> (ø)
src/mocks/store/store.ts 86.95% <0.00%> (ø)
src/mocks/series/series.ts 85.36% <0.00%> (ø)
src/mocks/scale/index.ts 100.00% <0.00%> (ø)
src/mocks/scale/scale.ts 77.77% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c540c8a...d0585b0. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested built and packages on kibana (lens and discover) looks to fix issue.

@nickofthyme nickofthyme merged commit 12b1135 into elastic:master Jun 16, 2020
markov00 pushed a commit that referenced this pull request Jun 16, 2020
## [19.5.2](v19.5.1...v19.5.2) (2020-06-16)

### Bug Fixes

* apply fixed positioning to hidden tooltip ([#716](#716)) ([12b1135](12b1135))
@markov00
Copy link
Member Author

🎉 This PR is included in version 19.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jun 16, 2020
@markov00 markov00 deleted the 2020_06_16-fix_popperjs_scroolbals branch June 17, 2020 10:43
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Issue released publicly :tooltip Related to hover tooltip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants