-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline time axis: collapsing some of the layers #1777
Comments
Thanks, @monfera for the details. I'm not fully sure how it will looks like in the attached screenshot you provided: are the 1st and 2nd layer merged together? Does that approach keep the number of layers consistent across various resolutions? |
In this case, the future layers would be:
Even now there's no static consistency: zooming alters what layers are present. So, Zoomed in, you may have mm:ss / hour / everything else, while zoomed out and losing the seconds, it becomes hh:mm / day / everything else |
@monfera understood thanks |
Just to wrap up what we discussed:
What we haven't discussed today: While the rasters and replacement rules give a good deal of flexibilty, one design consideration is the behavior of the time axis during zoom. For example, it would be possible to have a much longer set of rasters: currently, the hour only has subdivisions of 1, 5, 15 and 60 minutes. But there are other divisors of 60, such as 2, 3, 6, 10, 12 and 20. Including these would result a significant number of new rasters, and in that case it's worth considering automating the generation of both the rasters and the replacement rules, otherwise it'd be error prone. However the zoom behavior is a design constraint, consider these examples:
|
Multiline time axis: layer collapse
The multilayer time axis was introduced with this PR and has been in production for over half a year. A handful of feedback comments arrived, curated by Product Management. These express a wish to merge some of the layers, specifically, some elements of the time of the day, such as hours and minutes.
The current implementation does not merge time layers, hours and minutes are separate rows:
We're considering to make a change, though the modest feedback is a very weak signal: users who prefer it the current way, or are neutral about it are unlikely to speak up. There's always a potential for ultimately very few people to influence features (including ourselves) and it would require a lot of care to solicit feedback without making users feel that the "right" answer is to ask for a change or the other way around.
This issue explores the pros and cons, and the difficulties of the current layers vs. collapsed layers.
Pros of the distinct layers:
hh:mm
orhh:mm:ss
(or beyond) need more space thanhh
ormm
. This influences the possible grid resolution. A relatively high tick resolution generally allows quicker localization, because viewers are less reliant on the vertical grid lines, counting them and processing their saliency in the time hierarchyPros of the merged layers:
10:15
is easier to interpret as quarter past ten then two separate numbers on different rows,10
and15
. While we tried variations, such as postfixing the hour withh
(phased out) and postfixing minutes and seconds with prime markers′
and″
(currently active) some of the feedback we got explicitly mentioned unfamiliarity with the prime markers. Indeed, it's much less common thanhh:mm
and it's often reserved for indicating duration, as opposed to a point in timehh:mm
andhh:mm:ss
derive from standards, and are more universal and international than other markers such ash
for hours or the prime markershh:mm
,mm:ss
in competitive or complementary tools, even in case of multiple axis layersThe currently proposed layer merges are conservative in that they represent the smallest change, while making good on feedback:
hh:mm
)mm:ss
)hh:mm:ss
gets long, and the time loses more of its hierarchy; it can still be considered for a future implementationProposed logic:
hh:mm
layer)Note: there's already a generic substitution mechanism in place, because a specific time raster can already be present with multiple tick label lengths, such as months with no tick label (only grid/tick line); 1-letter month abbreviations; 3-letter month abbreviations; full month names
Post implementation tasks:
Filter user feedback, and reach out to the couple of users who asked for a change
The text was updated successfully, but these errors were encountered: