fix(xy): handle zero-length time domains and shed AM/PM for a 24hr time #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
added
bug
monfera
changed the title
monfera
changed the title
nickofthyme
pushed a commit
that referenced
this pull request
Nov 9, 2021
# [39.0.0](v38.1.5...v39.0.0) (2021-11-09) ### Bug Fixes * **deps:** update dependency @elastic/eui to v41 ([#1468](#1468)) ([0c38291](0c38291)) * **heatmap:** snap time bucket to calendar/fixed intervals ([#1462](#1462)) ([b76c12c](b76c12c)) * **xy:** handle zero-length time domains and switch to 24hr time ([#1464](#1464)) ([379c2d6](379c2d6)) ### BREAKING CHANGES * **heatmap:** The `xScaleType` is replaced by the prop `xScale`, which better describes a rasterized time scale with an Elasticsearch compliant interval.
|
🎉 This PR is included in version 39.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show multilayer time axis correctly for degenerate time domains (domain start equals domain end)
Details
Without the change to
visible_ticks.ts:With this change:
Issues
Checklist
:xy,:partition):interactions,:axis)[ ] The:themelabel has been added and the@elastic/eui-designteam has been pinged when there areThemeAPI changescloses #123,fixes #123)[ ] New public API exports have been added topackages/charts/src/index.ts[ ] Unit tests have been added or updated to match the most common scenarios[ ] The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)[ ] Visual changes have been tested with all available themes includingdark,light,eui-dark&eui-light