Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(partition): add get cursor pointer over slices #1428

Merged
merged 4 commits into from
Oct 20, 2021
Merged

fix(partition): add get cursor pointer over slices #1428

merged 4 commits into from
Oct 20, 2021

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Oct 15, 2021 •
edited
Loading

Summary

The cursor will be a pointer now with an onElementClick or onElementOver handler in the Settings and when hovering over the pie chart slices, treemap sectors, icicles, flames, mosaic and waffle pieces.

Oct-18-2021.07-41-22.mp4

Issues

Closes #1322

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • The proper documentation and/or storybook story has been added or updated
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@rshen91 rshen91 changed the title fix(partitions): add get cursor pointer selector fix(partition): add get cursor pointer selector Oct 15, 2021
@rshen91 rshen91 changed the title fix(partition): add get cursor pointer selector fix(partition): add get cursor pointer over slices Oct 15, 2021
@rshen91 rshen91 marked this pull request as ready for review October 15, 2021 15:03
@rshen91
Copy link
Contributor Author

rshen91 commented Oct 15, 2021

jenkins test this please

@rshen91 rshen91 requested review from nickofthyme, monfera and markov00 and removed request for nickofthyme October 18, 2021 13:54
markov00
markov00 approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, well done!

@rshen91 rshen91 merged commit af776ae into elastic:master Oct 20, 2021
@rshen91 rshen91 mentioned this pull request Oct 20, 2021
Closed
nickofthyme pushed a commit that referenced this pull request Oct 26, 2021
@semantic-release-bot
chore(release): 38.1.0 [skip ci]
de28b09 
# [38.1.0](v38.0.1...v38.1.0) (2021-10-26)

### Bug Fixes

* **partition:** add get cursor pointer over slices ([#1428](#1428)) ([af776ae](af776ae))

### Features

* **xy:** multilayer time axis ([#1430](#1430)) ([3d25854](3d25854))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 38.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Oct 26, 2021
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 38.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@monfera monfera Awaiting requested review from monfera

@nickofthyme nickofthyme Awaiting requested review from nickofthyme

Assignees
No one assigned
Labels
released on @38.1.x released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pie chart should have pointer cursor with onElementClick
3 participants
@rshen91 @nickofthyme @markov00