Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of onAnnotationClick #1357

Open
smith opened this issue Sep 3, 2021 · 1 comment
Open

Improve accessibility of onAnnotationClick #1357

smith opened this issue Sep 3, 2021 · 1 comment
Labels
:accessibility Accessibility related issue discuss To be discussed enhancement New feature or request

Comments

@smith
Copy link
Contributor

smith commented Sep 3, 2021

onAnnotationClick (added in #1293) doesn't seem to be keyboard accessible at all. I would expect tabbing through the document would focus the annotation rectangles (for RectAnnotation) and markers (for LineAnnotation.)

We implemented this in APM before this feature was available by using buttons for the markers and that seems to work: https://github.com/elastic/kibana/blob/3122e3f7e01063019916038757a25dcd16cb36f8/x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.tsx#L148-L166

@smith smith added bug Something isn't working :accessibility Accessibility related issue labels Sep 3, 2021
@rshen91 rshen91 self-assigned this Sep 3, 2021
@rshen91 rshen91 added the discuss To be discussed label Sep 7, 2021
@rshen91
Copy link
Contributor

rshen91 commented Sep 7, 2021

Due to the nature of canvas elements, we must create a custom mechanism for tracking what is selected within the canvas element. Currently no such mechanism exists, not even for tabbing through the geometry elements within the chart. This could be a next step towards accessibility.

We can however, make the line markers keyboard accessible as those elements are on the DOM and not canvas.

@rshen91 rshen91 removed their assignment Sep 9, 2021
@ghudgins ghudgins added enhancement New feature or request and removed bug Something isn't working labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:accessibility Accessibility related issue discuss To be discussed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants