fix(bar): filter zero-height bars from rendering

[rshen91]

Summary

The rect border does not render for bar charts with values smaller than the strokeWidth (including zero y-values).

Details

• does not render a bar if the height is 0 (f425d13)
• Independent from the bar border size, the border should not protrude out of the current bar and renders outside the bar size. In the example below, the border around { x: 'B', y: 20, val: 1222 }, should not exist since the y value is so small (d42a3f2)

<Chart renderer="canvas">
      <Settings theme={useBaseTheme()} />
      <Axis id="count" title="count" position={Position.Left} />
      <Axis id="x" title="goods" position={Position.Bottom} />
      <BarSeries
        id="bars"
        name="amount"
        xScaleType={ScaleType.Ordinal}
        xAccessor="x"
        yAccessors={['y']}
        barSeriesStyle={{
          rectBorder: {
            visible: true,
            strokeWidth: 10,
            stroke: 'black',
          },
        }}
        data={[
          { x: 'A', y: 0, val: 1222 },
          { x: 'B', y: 20, val: 1222 },
          { x: 'C', y: 750, val: 1222 },
          { x: 'D', y: 854, val: 1222 },
        ]}
      />
    </Chart>

Issues

Fixes #1279

Checklist

• The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
• The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
• Proper documentation or storybook story was added for features that require explanation or tutorials

[nickofthyme]

LGTM, tested locally.

[nickofthyme]

This is a tough choice, I would think to be consistent with the border something like...

But then the color is completely unknown for that bar so this...

would be better in that case. I think this is fine just wanted to make a mention of it. In any case this is hopefully a extreme edge case.

[rshen91]

I agree - hopefully this is an extreme edge case.

[nickofthyme]

🎉 This PR is included in version 33.2.1 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀