Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persisted color is broken #1264

Closed
nickofthyme opened this issue Jul 21, 2021 · 1 comment · Fixed by #1265
Closed

persisted color is broken #1264

nickofthyme opened this issue Jul 21, 2021 · 1 comment · Fixed by #1265
Assignees
Labels
bug Something isn't working Impact:Low :legend Legend related issue regression released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

Describe the bug
Changes in https://github.com/elastic/elastic-charts/pull/999/files#diff-b28b3197319ccdad650a47b8132e31a481b51374bc2eb6da6e0b1db3f881ecba broke colors with non-stateful color picker.

case SET_PERSISTED_COLOR:
return {
...state,
colors: {
...state.colors,
persisted: Object.fromEntries(
Object.entries(state.colors.persisted).filter(([key]) => !action.keys.includes(key)),
),
},
};

Notice action.color is never passed used to update the state in the reducer above.

Expected behaviour
Color is persisted in state

Screenshots
Screen Recording 2021-07-21 at 03 52 58 PM

Notice the color is temporarily set then removed after confirming selection

@nickofthyme nickofthyme added bug Something isn't working :legend Legend related issue regression Impact:Low labels Jul 21, 2021
@nickofthyme nickofthyme self-assigned this Jul 21, 2021
@nickofthyme
Copy link
Collaborator Author

🎉 This issue has been resolved in version 33.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Impact:Low :legend Legend related issue regression released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant