Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on the way the values are depicted inside bar charts #1123

Closed
5 tasks done
stratoula opened this issue Apr 19, 2021 · 4 comments
Closed
5 tasks done

Improvements on the way the values are depicted inside bar charts #1123

stratoula opened this issue Apr 19, 2021 · 4 comments
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :xy Bar/Line/Area chart related

Comments

@stratoula
Copy link

stratoula commented Apr 19, 2021

Is your feature request related to a problem? Please describe.
We received some feedback from our users that the values inside bar charts do not render ideally in all cases.

Describe the solution you'd like
Specifically, the problems identified are two:

Kibana Cross Issues
Kibana issue here

Checklist

Delete any items that are not applicable to this feature request.

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@stratoula stratoula added enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :xy Bar/Line/Area chart related labels Apr 19, 2021
@ghudgins
Copy link
Contributor

good discussion about this issue on elastic/kibana#101573

@markov00
Copy link
Member

markov00 commented Jul 8, 2021

@stratoula the following part of the request:

we could give the option to the users to hide the white outline if it doesn't fit their charts styling

can be achieved with the borderSize option available in the displayValue style of the chart theme:

export type DisplayValueStyle = Omit<TextStyle, 'fill' | 'fontSize'> & {
  offsetX: number;
  offsetY: number;
  fontSize:
    | number
    | {
        min: number;
        max: number;
      };
  fill:
    | Color
    | { color: Color; borderColor?: Color; borderWidth?: number } // borderWidth in pixel or
    | {
        textInvertible: boolean;
        textContrast?: number | boolean;
        textBorder?: number; // textBorder in pixel
      };
  alignment?: {
    horizontal: Exclude<HorizontalAlignment, 'far' | 'near'>;
    vertical: Exclude<VerticalAlignment, 'far' | 'near'>;
  };
};

@markov00
Copy link
Member

Hi @stratoula I will close this issue as it looks like we have closed all the tasks. Please reopen and add any missing task to the list if any

@stratoula
Copy link
Author

No Marco we are done with it! (at least for now) 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :xy Bar/Line/Area chart related
Projects
None yet
Development

No branches or pull requests

3 participants