Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review linter build tags #486

Closed
michel-laterman opened this issue May 31, 2022 · 0 comments · Fixed by #769
Closed

Review linter build tags #486

michel-laterman opened this issue May 31, 2022 · 0 comments · Fixed by #769
Assignees
@michel-laterman
Labels
Cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@michel-laterman
Copy link
Contributor

Currently the linter flags some issues speciically when dealing with files and build tags that target different distributions.

For example in #485:
Screen Shot 2022-05-31 at 12 24 55 PM

is stating that there is no vault.New declared, yet this function is part of all vault_*.go files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michel-laterman michel-laterman

Labels
Cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alter github action to run on different OSs michel-laterman/elastic-agent
1 participant
@michel-laterman