Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document default_container_logs setting of k8s provider #3158

Closed
ChrsMark opened this issue Aug 1, 2023 · 6 comments · Fixed by elastic/ingest-docs#380
Closed

Document default_container_logs setting of k8s provider #3158

ChrsMark opened this issue Aug 1, 2023 · 6 comments · Fixed by elastic/ingest-docs#380
Assignees
Labels
bug Something isn't working

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Aug 1, 2023

We missed the respective docs part for default_container_logs setting. It should have been added after #2386. Part of the #3063.

Docs need update:

@gizas
Copy link
Contributor

gizas commented Aug 3, 2023

Reopening because backport failed elastic/ingest-docs#380

Opened a new backport PR: elastic/ingest-docs#386

@ChrsMark
Copy link
Member Author

ChrsMark commented Aug 3, 2023

@gizas let's use this issue to summarize which PRs have been opened and for what reason. There were several ones opened/closed and I'm not sure what each one does/covers.

@gizas
Copy link
Contributor

gizas commented Aug 3, 2023

@ChrsMark only this for now: Opened a new backport PR: elastic/ingest-docs#386

This is related to backport to 8.9 (the previous failed to automatically backport)

@ChrsMark
Copy link
Member Author

ChrsMark commented Aug 3, 2023

Which one failed and why? I see elastic/ingest-docs#380 was merged but into main? Its tittle mentions "backport" though. So I struggle to follow which one was for which purpose. Could you please summarize here in this issue what PRs have been opened and why (even those those that failed)?

Also elastic/ingest-docs#386 would need to be linked to the original PR, see elastic/ingest-docs#386 (comment).

@gizas
Copy link
Contributor

gizas commented Aug 3, 2023

I updated elastic/ingest-docs#386 with links to original PR and closed duplicates. Now the only backport you should see is 386

@gizas
Copy link
Contributor

gizas commented Aug 4, 2023

Closing this as done after elastic/ingest-docs#386 was merged

@gizas gizas closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants