Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each shipper input unit should have a dedicated unix socket for inter-process communication #2581

Closed
Tracked by #16
cmacknz opened this issue May 1, 2023 · 2 comments
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented May 1, 2023

In elastic/beats#35135 (comment) the initial design of the shipper Filebeat input was finalized. One of the decisions was that each shipper input unit would implement its own gRPC server provisioned with a separate unix socket. Modify how the agent provisions the shipper to create a unix socket per input unit, instead of a single unix socket per shipper process.

image

We will need to decide what the naming convention for these unix sockets should be, considering that they must be unique per component that connects to the shipper and also that there can be multiple instances of a shipper. As outputs are added and removed from an agent policy over time the number of running shipper processes changes and the provisioned unix sockets must be removed in sync with this.

@jlind23
Copy link
Contributor

jlind23 commented May 27, 2024

@ycombinator @cmacknz is this issue still required now that the shipper project has been revisited?

@cmacknz
Copy link
Member Author

cmacknz commented May 27, 2024

Not needed anymore, closing.

@cmacknz cmacknz closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants