Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mage notice #1141

Closed
belimawr opened this issue Sep 9, 2022 · 1 comment
Closed

Fix mage notice #1141

belimawr opened this issue Sep 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@belimawr
Copy link
Contributor

belimawr commented Sep 9, 2022

The mage notice command has never been finalised (probably due to the lack of time), but we have a make rule that replaces it for the time being.

This issue is about using the implementation present on https://github.com/elastic/elastic-agent-libs to avoid code duplication and fixing all related issues.

One attempt has already been made on #1108, but due to time constraints, it was dropped in favour of the currently working make implementation.
@belimawr belimawr added the bug Something isn't working label Sep 9, 2022
@belimawr belimawr mentioned this issue Sep 9, 2022
Merged
6 tasks
@jlind23
Copy link
Contributor

jlind23 commented May 27, 2024

Mage notice has been removed in #1108 hence closing this.

@jlind23 jlind23 closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belimawr @jlind23