From 2b60ccf8da06fca193cb37a1186c2baa5c3b1f28 Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Wed, 28 Sep 2022 14:10:57 +0200
Subject: [PATCH] Fix status reporter initialization (#1341) (#1346)

(cherry picked from commit 177b5fbb92bead26bef2492cdc69871ef518ae69)

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
---
 internal/pkg/core/status/reporter.go      | 13 +++++++------
 internal/pkg/core/status/reporter_test.go | 18 ++++++++++++++++++
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/internal/pkg/core/status/reporter.go b/internal/pkg/core/status/reporter.go
index 50f34651fa1..e123beab2a2 100644
--- a/internal/pkg/core/status/reporter.go
+++ b/internal/pkg/core/status/reporter.go
@@ -88,10 +88,11 @@ type controller struct {
 // NewController creates a new reporter.
 func NewController(log *logger.Logger) Controller {
 	return &controller{
-		status:       Healthy,
-		reporters:    make(map[string]*reporter),
-		appReporters: make(map[string]*reporter),
-		log:          log,
+		status:         Healthy,
+		reporters:      make(map[string]*reporter),
+		localReporters: make(map[string]*reporter),
+		appReporters:   make(map[string]*reporter),
+		log:            log,
 	}
 }
 
@@ -154,12 +155,12 @@ func (r *controller) RegisterLocalComponent(componentIdentifier string) Reporter
 	return rep
 }
 
-// Register registers new component for status updates.
+// RegisterComponent registers new component for status updates.
 func (r *controller) RegisterComponent(componentIdentifier string) Reporter {
 	return r.RegisterComponentWithPersistance(componentIdentifier, false)
 }
 
-// Register registers new component for status updates.
+// RegisterComponentWithPersistance registers new component for status updates.
 func (r *controller) RegisterComponentWithPersistance(componentIdentifier string, persistent bool) Reporter {
 	id := componentIdentifier + "-" + uuid.New().String()[:8]
 	rep := &reporter{
diff --git a/internal/pkg/core/status/reporter_test.go b/internal/pkg/core/status/reporter_test.go
index 09a66661fc5..c4f6796fb30 100644
--- a/internal/pkg/core/status/reporter_test.go
+++ b/internal/pkg/core/status/reporter_test.go
@@ -14,6 +14,24 @@ import (
 	"github.com/elastic/elastic-agent/pkg/core/logger"
 )
 
+func TestNewController_ensure_all_is_initialzed(t *testing.T) {
+	l, _ := logger.New("", false)
+
+	newController := NewController(l)
+
+	c, ok := newController.(*controller)
+	if !ok {
+		t.Fatalf("expected c %T, not c %T", controller{}, newController)
+	}
+
+	c.reporters["ignore"] = &reporter{}
+	c.localReporters["ignore"] = &reporter{}
+	c.appReporters["ignore"] = &reporter{}
+	if c.log == nil {
+		t.Error("logger shouldn't be nil, it was not correctly assigned")
+	}
+}
+
 func TestReporter(t *testing.T) {
 	l, _ := logger.New("", false)
 	t.Run("healthy by default", func(t *testing.T) {