Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

Implement queue metrics for the disk queue #145

Open
Tracked by #16 ...
fearful-symmetry opened this issue Oct 25, 2022 · 2 comments
Open
Tracked by #16 ...

Implement queue metrics for the disk queue #145

fearful-symmetry opened this issue Oct 25, 2022 · 2 comments
Assignees
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@fearful-symmetry
Copy link
Contributor

The disk queue currently does not implement a metrics API:

https://github.com/elastic/beats/blob/d04da481f51c3f41b814106259145042baace857/libbeat/publisher/queue/diskqueue/queue.go#L284-L286

These are metrics used by self-monitoring in the shipper, as part of this issue: #11

These metrics API was designed with the memory queue in mind, so I'm not sure to what degree these metrics make sense for the disk queue, or how hard they might be to implement. Also not sure if this is something we want done by 8.6.

CC @cmacknz

@cmacknz
Copy link
Member

cmacknz commented Oct 25, 2022

The metrics to report are defined in #11, specifically we want:

  • The current configured maximum size of the disk queue in bytes.
  • The current utilization of the disk queue in bytes:
  • The age of the oldest item in the disk queue in nanoseconds.

@jlind23 jlind23 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 21, 2022
@pierrehilbert
Copy link
Contributor

@fearful-symmetry we need to check if elastic/beats#33471 is closing this one or not

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

4 participants