Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate benefits of switching to the new protobuf opaque API #126

Open
cmacknz opened this issue Dec 17, 2024 · 1 comment
Open

Investigate benefits of switching to the new protobuf opaque API #126

cmacknz opened this issue Dec 17, 2024 · 1 comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@cmacknz
Copy link
Member

cmacknz commented Dec 17, 2024

See https://go.dev/blog/protobuf-opaque for details

@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Dec 17, 2024
@belimawr
Copy link
Contributor

Reading the blog post, I believe we should migrate, accessing protobuf struct fields is very error prone (as shown in the blog post), the new opaque API prevents this while improving performance and paving the way for even more improvements in the future.

It's much easier and safer to have one consistent and safe API than expecting we won't write make mistakes while using proto structs or that they will be caught during reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

2 participants