Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Add a Flag in the ECS Generator to explicitly exclude one or more fields from the generated artifacts #1403

Closed
djptek opened this issue May 10, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@djptek
Copy link
Contributor

djptek commented May 10, 2021

Summary

Add a Flag in the ECS Generator to explicitly exclude one or more fields from the generated artifacts

Motivation:

Simplify Testing of Deprecation/Removal of Fields, avoiding need to generate a subset of e.g. all but one field

Detailed Design:

Add a flag "--excludeset" e.g.

python scripts/generator.py --ref v1.6.0 \
  --exclude-set       ../my-project/fields/exclude-set.yml \
  --include           ../my-project/fields/custom/ \
  --mapping-settings  ../my-project/fields/mapping-settings.json \
  --out               ../my-project/ \
  --subset            ../my-project/fields/subset.yml \
  --template-settings ../my-project/fields/template-settings.json
  • Field names

To be defined ad-hoc

  • Example values for the fields
---
- name: log
  fields:
    - name: original
  • Suggested appropriate datatypes

n/a

  • Any example events that map to the proposed use case(s)

See:
https://github.com/elastic/ecs/blob/master/rfcs/text/0017-remove-log-original.md
https://github.com/elastic/ecs/blob/master/rfcs/text/0022-remove-process-ppid.md

@djptek djptek added the enhancement New feature or request label May 10, 2021
@djptek djptek self-assigned this May 10, 2021
@kgeller
Copy link
Contributor

kgeller commented Jun 1, 2021

@djptek is this good to close?

@djptek
Copy link
Contributor Author

djptek commented Jun 2, 2021

Thanks for the reminder @kgeller this is addressed by merged PR #1411, closing

@djptek djptek closed this as completed Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants