Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated Numbering in Findings Flyout Remediation Section #2644

Open
uri-weisman opened this issue Oct 28, 2024 · 1 comment
Open

Truncated Numbering in Findings Flyout Remediation Section #2644

uri-weisman opened this issue Oct 28, 2024 · 1 comment
Labels
bug Something isn't working Team:Cloud Security Cloud Security team related
Milestone

Comments

@uri-weisman
Copy link
Contributor

Describe the bug
Some rules, such as CIS AWS 1.16, have double-digit remediation steps, which causes the remediation numbering to get truncated.

Preconditions
8.16 ELK stack + CSPM integration (probably can be reproduced in previous versions as well).

To Reproduce

  1. Create a 8.16 env
  2. Install the AWS CSPM integration.
  3. Observe the flyout of the CIS AWS 1.16 rule.
  4. The numbering of the remediation steps is truncated.

Expected behavior
Numbering is shown normally.

Screen.Recording.2024-10-28.at.10.01.37.mov
@uri-weisman uri-weisman added bug Something isn't working Team:Cloud Security Cloud Security team related labels Oct 28, 2024
@orouz
Copy link
Collaborator

orouz commented Oct 30, 2024

looking at the rule remediation data as it is in CIS_Amazon_Web_Services_Foundations_Benchmark_v1.5.0.xlsx, it seems the original data has correct line numbers:

**From Console:**
...
1. Sign in to the AWS Management Console and open the IAM console at [https://console.aws.amazon.com/iam/](https://console.aws.amazon.com/iam/).
2. In the navigation pane, click Policies and then search for the policy name found in the audit step.
3. Select the policy that needs to be deleted.
4. In the policy action menu, select first `Detach` 
5. Select all Users, Groups, Roles that have this policy attached
6. Click `Detach Policy` 
7. In the policy action menu, select `Detach` 

then:

**From Command Line:**
....

1. Lists all IAM users, groups, and roles that the specified managed policy is attached to.
...

note these instructions are for different remediation processes: from console / from command line

i think the issue is somewhere here:

def check_and_fix_numbered_list(text):

@acorretti acorretti added this to the 8.18 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Cloud Security Cloud Security team related
Projects
None yet
Development

No branches or pull requests

3 participants