Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kibana - Group By - Resource records with zero failed findings are colored in red #132

Closed
uri-weisman opened this issue May 12, 2022 · 3 comments
Assignees
Labels
bug Something isn't working verified label for fixed and retested issues

Comments

@uri-weisman
Copy link
Contributor

Describe the bug
In the Group by resource id table, resource records with zero failed findings are colored in red.

Preconditions
Kibana + ES + CIS k8s integration installed.
Elastic agent deployed on a k8s cluster.

To Reproduce
Steps to reproduce the behavior:

  1. Enter Kibana and navigate to the Cloud Security section.
  2. Go to the findings page.
  3. Apply a search that will provide results.
  4. Click on the Group by dropdown list and select Resource.
  5. Notice that rows with zero failed findings are colored in red.

Expected behavior
Should be colored in green or any other indication for none failed findings.

Screenshots

Screen Shot 2022-05-11 at 17 36 58

Tested locally, not by using a snapshot
Kibana Version: 8.3.0 commit sha: 63f2d6647113d66cbb97039a8a780b76644ef727

@uri-weisman uri-weisman added bug Something isn't working csp: last mile labels May 12, 2022
@kfirpeled
Copy link
Contributor

@tinnytintin10 , @einatjacoby what color would you like for 0 failed findings? black or green? or something else?

@tinnytintin10
Copy link

@kfirpeled let's go with green. Should look something like:

failingFindingsCountColor

@kfirpeled
Copy link
Contributor

kfirpeled commented May 22, 2022

solved in elastic/kibana#132529

We decided to go with black and add a tooltip on hover that shows the total count of findings

@kfirpeled kfirpeled self-assigned this May 22, 2022
@oren-zohar oren-zohar added the verified label for fixed and retested issues label Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified label for fixed and retested issues
Projects
None yet
Development

No branches or pull requests

4 participants