We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It would be nice to use validate_only query parameter when creating/updating a deployment to just validate the deployment definition. It looks like the elastic client does support the param, but the elastic api doesn't yet. https://www.elastic.co/guide/en/cloud-enterprise/current/create-deployment.html
validate_only
Add a property for ValidateOnly to CreateParams/UpdateParams struct and pass them when calling CreateDeployment/UpdateDeployment
type UpdateParams struct { *api.API ... // Optional values SkipSnapshot bool HidePrunedOrphans bool ValidateOnly bool // Added } func Update(params UpdateParams) (*models.DeploymentUpdateResponse, error) { ... res, err := params.V1API.Deployments.UpdateDeployment( deployments.NewUpdateDeploymentParams(). WithDeploymentID(params.DeploymentID). WithBody(params.Request). WithSkipSnapshot(¶ms.SkipSnapshot). WithHidePrunedOrphans(¶ms.HidePrunedOrphans). WithValidateOnly(¶ms.ValidateOnly), // Added params.AuthWriter, ) ... return res.Payload, nil }
I couldn't find any test code for params, but I'm happy to add a test case
It's always nicer to allow user to validate the deployment definition first before creating/updating a deployment
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Overview
It would be nice to use
validate_only
query parameter when creating/updating a deployment to just validate the deployment definition. It looks like the elastic client does support the param, but the elastic api doesn't yet.https://www.elastic.co/guide/en/cloud-enterprise/current/create-deployment.html
Possible Implementation
Add a property for ValidateOnly to CreateParams/UpdateParams struct and pass them when calling CreateDeployment/UpdateDeployment
Testing
I couldn't find any test code for params, but I'm happy to add a test case
Context
It's always nicer to allow user to validate the deployment definition first before creating/updating a deployment
The text was updated successfully, but these errors were encountered: