Multiple duration fields for better elasticseach storage for controllermanager #32486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelKatsoulis
added
bug
Team:Cloudnative-Monitoring
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ChrsMark
approved these changes
Jul 26, 2022
4 tasks
9 tasks
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…ermanager (#32486) * Multiple duration fields for better elasticseach storage * Update controllermanager dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Due to the new fields introduced in controllermanager metricset in #32037
kubernetes.controllermanager.client.request.duration.sec.bucket.*kubernetes.controllermanager.workqueue.work.duration.sec.bucket.*there was a bug created.
Because of the histogram buckets of
client.request.duration.secthe following fields where created.The problem is that the field
0.128is stored in elasticsearch encapsulated likewhich then leads to the elastic package marking the
client.request.duration.sec.bucket.0.128as undefined.For this reason the buckets are multiplied by 10^6 to be converted from seconds to microseconds , so that the field will be an integer.
Also the field
kubernetes.controllermanager.workqueue.work.duration.sec.bucket.*will be deleted and reconsidered in the next release as the fields created likekubernetes.controllermanager.workqueue.work.duration.sec.bucket.0.000009999999999999999cannot be meaningfully multiplied yet to become integers.Dashboard is also updated.