Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Leverage higher's resource updates to keep metadata and hints-based configurations in sync #23139

Closed
ChrsMark opened this issue Dec 15, 2020 · 3 comments · Fixed by #29289
Assignees
Labels
enhancement Team:Platforms Label for the Integrations - Platforms team

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Dec 15, 2020

Describe the enhancement:
Update pod's metadata, and related hints-based configurations when node metadata or namespace metadata getting updated.

Describe a specific use case for the enhancement or feature:
(from a @jsoriano 's old comment):
An issue we have is that namespace metadata and hints are used when available when a pod is created or updated. But, if the namespace is modified, its metadata is not updated in pods events, and hints-based autodiscover is not retriggered. Pods need to be updated so the info from its namespaces is leveraged.
Perhaps we could have higher-level watchers and indexers that keep all the related metadata on sync, and this wouldn't be optional. E.g. the higher level pod watcher/informer would always internally have watchers/informers for pods, nodes and namespaces and would trigger updates with all the data if any of them change. The watcher used in add_kubernetes_metadata should do the same.

@ChrsMark ChrsMark added the Team:Platforms Label for the Integrations - Platforms team label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark
Copy link
Member Author

This is fixed for namespaces at #25117. @jsoriano I guess the same approach could be used for node's metadata too, right? If so we can work on it and completely fix this.

@jsoriano
Copy link
Member

This is fixed for namespaces at #25117. @jsoriano I guess the same approach could be used for node's metadata too, right? If so we can work on it and completely fix this.

Yes, in principle the same approach could be used for other related metadata. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants