-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce proper init system (/bin/tini) to Docker container #22137
Conversation
I can backport the change when it is merged, we use backport
|
dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaime Soriano Pastor <[email protected]>
/package |
/package |
@mieciu package tests are failing, with this error:
I think this is happening because Could you please replace appearances of Thanks! (Another solution could be to make tests aware of symlinks, but not sure how hard this would be as we are reading the layers as tar files). |
/package |
Pinging @elastic/integrations (Team:Integrations) |
dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaime Soriano Pastor <[email protected]>
/package |
LGTM, but lets wait for a last CI run. Thanks @mieciu! |
Ignoring failure in E2E tests by now, they are passing in master, but they are failing in other PRs too, like in this one: #22879. @mdelapenya could be something wrong with E2E tests for PRs? Master and nightly builds seem to be working fine. |
I am backporting this to 7.x so it will be in 7.11 (#22982). @kuisathaverat I see you also added labels for 7.10 and 7.9. Is this change needed in these versions? I would prefer not to make this change on versions already released. |
Introduce tini as init system for Docker containers. Tini is the init system used in docker images of other Elastic products. It implements basic init functionality as reaping zombie processes and properly handle signals. (cherry picked from commit ee50020)
I forgot adding a changelog, adding it here: #22983 |
Introduce tini as init system for Docker containers. Tini is the init system used in docker images of other Elastic products. It implements basic init functionality as reaping zombie processes and properly handle signals. (cherry picked from commit ee50020) Co-authored-by: Przemysław Hejman <[email protected]>
What does this PR do?
🚧 Work in progress, there's probably more to come
This PR introduces init system (
tini
- ref: https://github.com/krallin/tini) for reaping zombie processes and proper signal forwarding. It also enables running processes with non-default UID/GID.Why is it important?
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs