revert WSS process reporting for windows #22055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
kaiyan-sheng
approved these changes
Oct 21, 2020
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 21, 2020
* revert WSS process reporting for windows * add changelog (cherry picked from commit ba2b2f9)
3 tasks
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Oct 21, 2020
* revert WSS process reporting for windows * add changelog (cherry picked from commit ba2b2f9)
fearful-symmetry
added a commit
that referenced
this pull request
Oct 21, 2020
fearful-symmetry
added a commit
that referenced
this pull request
Oct 21, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 22, 2020
…uild-retry-docker-if-error-packaging * upstream/master: Fix the url of reviewdog (elastic#21981) revert WSS process reporting for windows (elastic#22055) Fix typo (elastic#19585) (elastic#22061)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 22, 2020
* upstream/master: (27 commits) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079) [build][packaging] Add resilience when docker build (elastic#22050) Fix the url of reviewdog (elastic#21981) revert WSS process reporting for windows (elastic#22055) Fix typo (elastic#19585) (elastic#22061) [Ingest Manager] Use ML_SYSTEM to detect if agent is running as a service (elastic#21884) Prevent log input from sending duplicate messages due to file renaming (elastic#21911) feat: package aliases for snapshots (elastic#21960) [DOC] Add firewall as possible troubleshooting issue (elastic#21743) [Filebeat] Add max_number_of_messages config parameter for S3 input (elastic#21993) [Elastic Agent] Fix missing elastic_agent event data (elastic#21994) Document auditbeat system process module config (elastic#21766) Update links (elastic#22012) dynamically find librpm (elastic#21936) Fix Istio docs (elastic#22019) [beats-tester][packaging] store packages in another location (elastic#21903) [Kubernetes] Remove redundant dockersock volume mount (elastic#22009) [Ingest Manager] Always try snapshot repo for agent upgrade (elastic#21951) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Oct 26, 2020
…beats into feature/support-flaky-test-analyser * 'feature/support-flaky-test-analyser' of github.com:v1v/beats: (40 commits) [CI] support windows-10 (elastic#19804) Use default config when creating the input (elastic#22126) Change x509 mappings from file. to tls.server. (elastic#22097) Add fleet settings image (elastic#22065) Edit 7.9.3 changelog (elastic#22117) Edit 6.8.13 release notes (elastic#22120) Incorporate librpm fix feedback (elastic#22098) [libbeat] Add more disk queue unit tests and fix a size-check bug (elastic#22107) docs: move kerberos include (elastic#22109) Check context.Canceled and fix s3 input config (elastic#22036) Add max_number_of_messages into aws filebeat fileset vars (elastic#22057) Remove suricata.eve.timestamp alias (elastic#22095) [Ingest Manager] Use symlink path for reexecutions (elastic#21835) chore: use ubuntu 18 as linux agent (elastic#22084) docs: Prepare Changelog for 7.9.3 (elastic#22073) (elastic#22075) docs: Prepare Changelog for 6.8.13 (elastic#22072) (elastic#22079) [build][packaging] Add resilience when docker build (elastic#22050) Fix the url of reviewdog (elastic#21981) revert WSS process reporting for windows (elastic#22055) Fix typo (elastic#19585) (elastic#22061) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts the change to report
system.process.memory.rssaswsson windows.Why is it important?
@mukeshelastic and I decided that this change was unnecessary. We're reporting what is fundamentally the same metric as two different fields depending on the OS. This is particularly burdensome for users wanting to make queries against these fiends across OS. When we have the opportunity to make breaking changes, we may want to rename this to
system.process.memory.pctor something similar.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
memory.rssis present on the system/process metricset