-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable script processor for Metricbeat #14711
Conversation
@andrewkroh pinging you just in case there is some good reason not to do this. I see initially this was done mainly for Filebeat |
LGTM based on references to other beats. Nice! |
Take into account that light modules don't support processors at the moment. |
yes, I noticed it, as of now the workaround would be to add the processor in the Any plans to add support at the manifest level? that would be cool |
I introduced these changes into fresh ActiveMQ module and it seems to report correctly:
|
Yep, it would work in the config, but distributing logic this way can be error-prone, for example on upgrades the script wouldn't get updated if it is in the config.
Yes, this would increase a lot the possibilities of light modules, specially having the script processor. There are no plans for this yet, we could increase priority of that if we consider it valuable. From what I remember from implementing light modules, the problem with adding processors support can be that they are configured with the pipeline before the module is loaded, but with light modules we wouldn't know what processors to add till we load the module. So we will need some mechanism to add processors to the pipeline during module instantiation, or a way to add a "pipe" to process events before sending them to the pipeline. I will create an issue for that. |
Added issue for processors in light modules #14740 |
* Enable script processor for Metricbeat (cherry picked from commit 829a29e)
* Enable script processor for Metricbeat (cherry picked from commit 829a29e)
…5633) * Enable script processor for Metricbeat (#14711) * Enable script processor for Metricbeat (cherry picked from commit 829a29e) * Fix: changelog Co-authored-by: Carlos Pérez-Aradros Herce <[email protected]>
…5632) * Enable script processor for Metricbeat (#14711) * Enable script processor for Metricbeat (cherry picked from commit 829a29e) * Fix: changelog Co-authored-by: Carlos Pérez-Aradros Herce <[email protected]>
This PR enables the
script
processor in Metricbeat. We can use it for some data conversion in events coming from Lightweight modules.