Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we write support file to disk (Registry, Keystore) #5755

Closed
ph opened this issue Nov 29, 2017 · 1 comment
Closed

Refactor how we write support file to disk (Registry, Keystore) #5755

ph opened this issue Nov 29, 2017 · 1 comment

Comments

@ph
Copy link
Contributor

ph commented Nov 29, 2017

Currently beats only write state with the registry with the addition of the Keystore in #5687 we will have another way to write content to disk. We should refactor the writing to disk to a common abstraction that can be used in both context.

A few things that need to be supported:

  • Write to a temporary file
  • Replace an existing file
  • If something go wrong abort and keep the original file in place.
  • Fix any corner case on shutdown

Related code:

@kvch
Copy link
Contributor

kvch commented Dec 20, 2019

Issue is tracked here as well: #12908

@kvch kvch closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants