Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete docker-compose package used to run system tests #38914

Open
cmacknz opened this issue Apr 12, 2024 · 1 comment
Open

Replace obsolete docker-compose package used to run system tests #38914

cmacknz opened this issue Apr 12, 2024 · 1 comment
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@cmacknz
Copy link
Member

cmacknz commented Apr 12, 2024

The currently obsolete docker-compose package used to run system tests recently caused all tests to fail when the version of docker in our CI runners was upgraded. A work around was used to get around this by forking the upstream package. See #38743 and https://github.com/pkoutsovasilis/compose. We need to get rid of the forked version of https://github.com/pkoutsovasilis/compose.

Switching our compose implementation https://github.com/gabrieldemarmiesse/python-on-whales seems like the easiest path at present. We could also manually rewrite the compose client to shell out the command line, or take on the entire task of rewriting the system tests in Go.

Several WIP PRs switching to Python on Whales were started by need to be continued:

This is the class we need to rewrite:

class ComposeMixin(object):
"""
Manage docker-compose to ensure that needed services are running during tests
"""
# List of required services to run INTEGRATION_TESTS
COMPOSE_SERVICES = []
# Additional environment variables for docker compose
COMPOSE_ENV = {}
# timeout waiting for health (seconds)
COMPOSE_TIMEOUT = 300
# add advertised host environment file
COMPOSE_ADVERTISED_HOST = False
# port to advertise when COMPOSE_ADVERTISED_HOST is set to true
COMPOSE_ADVERTISED_PORT = None
@classmethod
def compose_up(cls):

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Apr 12, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants