Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Pip install doesn't work on windows tests #32994

Closed
andrewvc opened this issue Sep 6, 2022 · 3 comments
Closed

[Heartbeat] Pip install doesn't work on windows tests #32994

andrewvc opened this issue Sep 6, 2022 · 3 comments
Labels
build-failures Build failures in the CI. build-system Issue or change affecting Mage, Make, or build scripts. Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Sep 6, 2022

Now that https://github.com/elastic/beats/pull/32937/files is merged #30632 no longer passes with errors such as the following:

[2022-09-01T21:51:57.634Z] DONE 14 tests in 74.803s

[2022-09-01T21:51:59.665Z] >> go test: Unit Test Passed

[2022-09-01T21:52:08.306Z] >> python test: Unit Testing

[2022-09-01T21:52:30.845Z] ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\AppData\\Local\\Temp\\pip-uninstall-d3e3cua0\\pip.exe'

[2022-09-01T21:52:30.846Z] Consider using the `--user` option or check the permissions.

I assume #32937 was green when merged, but perhaps that wasn't the case. I think there was a misunderstanding, I had thought that we had disabled those windows tests that were failing in that PR, but it seems we did not do that.

We should disable those as they provide very little real value and are not worth maintaining.

@andrewvc andrewvc added Team:obs-ds-hosted-services Label for the Observability Hosted Services team build-system Issue or change affecting Mage, Make, or build scripts. build-failures Build failures in the CI. labels Sep 6, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@v1v
Copy link
Member

v1v commented Sep 7, 2022

I think ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\AppData\\Local\\Temp\\pip-uninstall-d3e3cua0\\pip.exe' is not relevant since it happens always as we discussed in #32937 (comment) and #32937 (comment)

I'm a bit confused what to do in here, I guess the uptime can decide how they would like to proceed, either disabling the tests or reverting #32937 if that's the case, and if so then comment out in #23957 and #23958, or maybe something else

@v1v v1v removed their assignment Sep 8, 2022
@andrewvc
Copy link
Contributor Author

Closing, I disabled the windows build steps in #32937 . The issue is that docker-compose is not available on windows for integration tests. Maybe we can fix these in a subsequent issue, but TBH it's not at the top of our priority list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-failures Build failures in the CI. build-system Issue or change affecting Mage, Make, or build scripts. Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

No branches or pull requests

3 participants