Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] GCP module should not error when period is less than minimum #30434

Closed
endorama opened this issue Feb 16, 2022 · 3 comments · Fixed by #40020
Closed

[Metricbeat] GCP module should not error when period is less than minimum #30434

endorama opened this issue Feb 16, 2022 · 3 comments · Fixed by #40020
Assignees
Labels
enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Comments

@endorama
Copy link
Member

Describe the enhancement: Currently GCP module errors when a period less than a minimum given by GCP APIs is specified. It should not produce an error, correct the value to the minimum and produce a warning log message.

Describe a specific use case for the enhancement or feature: gpc.compute integration package specify a default period of 10s. When the integration is installed and setup to collect metrics from GCP metricbeat fails initializing data collection. This behaviour is correct but suboptimal, as debugging it requires delving into the Elastic Agent logs (identifying this issue from the log console in Kibana failed me multiple times). Given that the minimal period is known, is possible to correct this error without requiring user input.

Separately this should be addressed in the integration configuration by updating the default value and specifying the minimum valid value in the description.

@endorama endorama self-assigned this Feb 16, 2022
@endorama endorama added Team:Cloud-Monitoring Label for the Cloud Monitoring team enhancement labels Feb 16, 2022
@ishleenk17
Copy link
Contributor

@endorama
I am working on the GCP Improvements.
I see that the default value of period is 1 minute in beats and in integrations.
Only a mention in the description about the minimum period should be sufficient here ?

@endorama
Copy link
Member Author

endorama commented Nov 2, 2023

@ishleenk17 thank you!

Only a mention in the description about the minimum period should be sufficient here ?

I don't think so. The main issue is that if you specify 30 seconds in the beat or integration configuration, the underlying collector is going to halt due to an error. Debugging these errors is difficult, especially in complex configurations.
I think the outcome we want (for our customers and our troubleshooting efforts) is: it should not produce an error, correct the value to the minimum and produce a warning log message for inspections by human.

@ishleenk17 ishleenk17 removed the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Nov 24, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2023
@ishleenk17 ishleenk17 assigned ishleenk17 and unassigned endorama Nov 24, 2023
@ishleenk17 ishleenk17 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Nov 24, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2023
@lalit-satapathy
Copy link
Contributor

@ishleenk17, Can this be moved to backlog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
3 participants