Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Prefer hot data tiers #30411

Closed
jakelandis opened this issue Feb 15, 2022 · 6 comments
Closed

[7.x] Prefer hot data tiers #30411

jakelandis opened this issue Feb 15, 2022 · 6 comments
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify good first issue Indicates a good issue for first-time contributors Stalled Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@jakelandis
Copy link

jakelandis commented Feb 15, 2022

Starting in 7.16 Beats started using a composable index templates by default. Composable index templates will always take precedence over legacy index templates, meaning that an index patterns that match both composable and legacy templates, the legacy templates will be ignored.

Normally this is fine and generally desired. However, prior to this change it was possible to declare a legacy index template to match on * (i.e. all indices) to default index settings to ensure that indices were first allocated on the hot node. Since Beats are now using composable index templates this type of pattern will no longer work. For systems which relied on that * pattern for hot allocation, they will now loose the ability to default to hot nodes.

I would like to request the following index setting be the default for Beats 7.x :

"index.routing.allocation.include._tier_preference" : "data_hot,data_content"

This says prefer data_hot if present, else use data_content. If no node roles are configured for data tiers this is still OK and won't break anything since every node will logically get every data_* node role. However, if node roles are present then with this change new indices will prefer hot nodes.

This is not necessary for 8.x defaults since 8.x Beats default to use data streams and data streams have an implicit default of data_hot.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 15, 2022
@nimarezainia nimarezainia added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 16, 2022
@kvch kvch added the good first issue Indicates a good issue for first-time contributors label Feb 16, 2022
@jlind23 jlind23 added the backport-7.17 Automated backport to the 7.17 branch with mergify label Feb 21, 2022
@jlind23
Copy link
Collaborator

jlind23 commented Mar 21, 2022

@nimarezainia @cmacknz do you think we should make it land in 7.17?

@cmacknz
Copy link
Member

cmacknz commented Mar 21, 2022

The change seems trivial to make, it just a question of having some available to do it.

Most of the effort would be in testing to confirm that the setting is applied as expected, and perhaps confirming that there are no backwards compatibility concerns as the description states.

@botelastic
Copy link

botelastic bot commented Mar 21, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 21, 2023
@VimCommando
Copy link

This is still relevant, especially given 7.17 will be supported until 9.x is released; plus 7.17 is the recommended upgrade path to 8.x. This update helps smooth that transition.

@botelastic botelastic bot removed the Stalled label Mar 21, 2023
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Mar 21, 2023
@botelastic
Copy link

botelastic bot commented Mar 20, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 20, 2024
@botelastic botelastic bot closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify good first issue Indicates a good issue for first-time contributors Stalled Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

7 participants