Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic metricbeat testing against stack snapshots #30146

Closed
7 tasks done
matschaffer opened this issue Feb 1, 2022 · 11 comments
Closed
7 tasks done

Automatic metricbeat testing against stack snapshots #30146

matschaffer opened this issue Feb 1, 2022 · 11 comments

Comments

@matschaffer
Copy link
Contributor

matschaffer commented Feb 1, 2022

The logstash image used for metricbeat module testing is quite old (7.12), which led to this PR #29440

But after some team discussion we decided it would be best to:

  • Set docker-compose to 8-SNAPSHOT (for golang tests)
  • Add supported-versions.yml that references 7.x-SNAPSHOT & 8.x-SNAPSHOT to test against both revisions (for python tests)
  • Lock the above to a known-good docker image sha
  • Update bump-stack-version to update the logstash docker-compose and supported versions files as part of the nightly snapshot flow

Subtasks:

cc @jsoriano @v1v

@matschaffer matschaffer added Team:Integrations Label for the Integrations team Feature:Stack Monitoring labels Feb 1, 2022
@matschaffer matschaffer self-assigned this Feb 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@matschaffer
Copy link
Contributor Author

Also, once we have this sorted out we'll probably want to do the same for any module that monitors something we produce. (es, kibana, entsearch, ... beats?)

@matschaffer matschaffer changed the title Automatic metricbeat testing against logstash snapshots Automatic metricbeat testing against stack snapshots Feb 4, 2022
@matschaffer
Copy link
Contributor Author

Heads up @jasonrhodes, @smith, @ruflin - I've turned this into an Epic and split out sub issues.

If we really want to get to an "ideal" state there's a fair bit more work than just the logstash docker-compose file getting updated.

@matschaffer matschaffer removed their assignment Feb 4, 2022
@miltonhultgren
Copy link
Contributor

@matschaffer I made this type:epic, hope that's correct!

@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2022

++ on driving this effort forward across all stack modules. This covers the metrics case. We should also discuss the metrics case especially around testing with "snapshot" logs.

@matschaffer
Copy link
Contributor Author

@smith since this is an epic that will span cycles I've removed it from the current iteration

@jasonrhodes
Copy link
Member

Doing a deep sweep of some old GH notifications that got lost.

@matschaffer @smith I don't have a good sense of the priority of this effort as it relates to other things we'd like to do with Stack Monitoring. This likely belongs in a single "Tech Debt / Testing" Work Queue that we can constantly re-order to make sure we are focused on the most important work from that stream without overdoing it, but for right now I think that means "the backlog", yes?

@matschaffer
Copy link
Contributor Author

"backlog" works for me.

I agree with the shortcoming. We don't currently have good comprehensive testing of our modules on our own products. But given "platform observability" efforts, I'm not sure it's worth making the investment to fix it.

@botelastic
Copy link

botelastic bot commented Jul 25, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 25, 2023
@smith
Copy link
Contributor

smith commented Jul 25, 2023

We are not planning on doing this at this time.

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants