Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Some files required by make check aren't updated by make update #26454

Closed
faec opened this issue Jun 23, 2021 · 4 comments
Closed

[build] Some files required by make check aren't updated by make update #26454

faec opened this issue Jun 23, 2021 · 4 comments
Labels
bug Stalled Team:Elastic-Agent Label for the Agent team

Comments

@faec
Copy link
Contributor

faec commented Jun 23, 2021

As discovered in #26419, some files that can cause make check to fail aren't updated on make update, as in the following output:

Error: some files are not up-to-date. Run ‘make update’ then review and commit the changes. Modified: [filebeat/input/syslog/format_check.go]

filebeat/input/syslog/format_check.go is the only file where I've seen this so far, though there may be others. To reproduce, edit format_check.go and change the indentation level of some line so that it fails the linter; make update will leave it untouched but make check will fail (leaving a corrected file in place).

A workaround for this is to simply run make check instead of make update, but this is clearly not intentional or documented, so as long as we're still using make update we should keep its behavior in sync with the checks.

@faec faec added bug Team:Elastic-Agent Label for the Agent team labels Jun 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic
Copy link

botelastic bot commented Jun 23, 2022

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 23, 2022
@botelastic botelastic bot closed this as completed Dec 20, 2022
@faec
Copy link
Contributor Author

faec commented Dec 20, 2022

We really should have a build system that fits its own documentation for a command that is run on every checkin.

@faec faec reopened this Dec 20, 2022
@botelastic botelastic bot removed the Stalled label Dec 20, 2022
@botelastic
Copy link

botelastic bot commented Dec 20, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 20, 2023
@botelastic botelastic bot closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Stalled Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants