-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default HTTP User Agent string #21975
Comments
Pinging @elastic/integrations-services (Team:Services) |
We could use the existing User agent generator: https://github.com/elastic/beats/blob/master/libbeat/common/useragent/useragent.go#L29 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
IIUC this has been implemented by @michel-laterman in #27509 and will be present in 7.16.0? @michel-laterman, can you confirm and close? |
yes, sorry about the delay this item should already be handled |
The default user agent string for HTTP requests by Beats is
Go-http-client/1.1
. The string is set by the go stdlib: https://github.com/golang/go/blob/606d4a38b9ae76df30cc1bcaeee79923a5792e59/src/net/http/request.go#L512For Beats we should have a more complete string, that contains the product name+version, the libbeat version, to go version, and OS. For example:
<Beatname> <version> (<os+arch-string>, libbeat: <version>, go: <version>)
.The text was updated successfully, but these errors were encountered: